Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix data race in test #20142

Merged
merged 3 commits into from
Sep 22, 2020
Merged

executor: fix data race in test #20142

merged 3 commits into from
Sep 22, 2020

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #20109 #20079

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:
Use config.UpdateGlobal instead of modifying the value directly.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

N/A

Side effects

N/A

Release note

  • No release note

@XuHuaiyu XuHuaiyu requested a review from a team as a code owner September 22, 2020 06:22
@XuHuaiyu XuHuaiyu requested review from wshwsh12 and qw4990 and removed request for a team September 22, 2020 06:22
@github-actions github-actions bot added the sig/execution SIG execution label Sep 22, 2020
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 22, 2020
@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@XuHuaiyu merge failed.

@XuHuaiyu
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 650515a into pingcap:master Sep 22, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20146

ti-srebot added a commit that referenced this pull request Oct 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/executor component/test sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA_RACE:github.com/pingcap/tidb/executor.ResetContextOfStmt() failed
4 participants